perf: apply clang-tidy performance checks #3393

scarf005 · 2023-10-08T14:15:05Z

BIOPROOF distribution: Robots (BIOPROOF distribution: Robots #3227)
Fix NPCs set to attack what you attack charging blindly (Fix NPCs set to attack what you attack charging blindly #3226)
Allow steel and superalloy lining for more items (Allow steel and superalloy lining for more items #3228)
Add some more basic armor items (Add some more basic armor items #3221)
feat: simplify friendly swap and pushing (feat: simplify friendly swap and pushing #3232)
Give No Hope the e (Give No Hope the e #3246)
fix: allow elevator misalignment (fix: allow elevator misalignment #3181)
ci: remove unused workflow files (ci: remove unused workflow files #3245)
build: remove chkjson (build: remove chkjson #3247)
UDP External Tileset Update (UDP External Tileset Update #3244)
Proper river shores under bridges (Proper river shores under bridges #3212)
Fixed some issues with bridge/road generation on overmap edge (Fixed some issues with bridge/road generation on overmap edge #3203)
docs: migrate external tilest info (docs: migrate external tilest info #3249)
build(cmake): deduplicate library setup (build(cmake): deduplicate library setup #3248)
ci: use merge queue (ci: use merge queue #3252)
docs: lang/notes (docs: lang/notes #3207)
Fix compile error on MacOS curses (Fix compile error on MacOS curses #3260)
Refresh test user dir on each test run (Refresh test user dir on each test run #3259)
feat: show monster immunity in description (feat: show monster immunity in description #3254)
Allow filling containers directly from blood draw kit (Allow filling containers directly from blood draw kit #3262)
Streamline has_trait_flag behavior (Streamline has_trait_flag behavior #2911)
Add more grid battery options (Add more grid battery options #3264)
Add street lights to more places, allow deconstructing (Add street lights to more places, allow deconstructing #3265)
feat: animal ears are cute (feat: animal ears are cute #3230)
fix: lab README symlink (fix: lab README symlink #3263)
Missing tile in horse ranches (Missing tile in horse ranches #3274)
Update iexamine_elevator.cpp (Update iexamine_elevator.cpp #3276)
submap rotate fixes
perf: speed up item::has_flag calls (perf: speed up item::has_flag calls #3277)
perf(map): inline sm_to_ms_copy (perf(map): inline sm_to_ms_copy #3278)
Properly remove stale test user dir (Properly remove stale test user dir #3270)
Mainline Stone Chisel (Mainline Stone Chisel #3279)
perf: change frequency of weapon value (perf: change frequency of cached weapon value update #3283)
Reworked lake shore (Reworked lake shore mapgen for better connection with rivers #3275)
Fix eternal drowning when NPC is thrown into deep water. (Fix eternal drowning when NPC is thrown into deep water. #3269)
perf: cache character's dead state (perf: cache character's dead state #3282)
Add a construction to convert street lights to use local power (Add a construction to convert street lights to use local power #3273)
ci: don't skip checks in merge group (ci: don't skip checks in merge group #3285)
fix: only set cached_dead_state if npc is actually dead (fix: only set cached_dead_state if npc is actually dead #3287)
Shouldn't use uint
And the rest
build: bump android ndk (build: bump android ndk #3289)
Canned tomatoes should no longer appear half-full (Canned tomatoes should no longer appear half-full #3291)
Fix monsters attacking across z levels when the wander/scentmove (Fix monsters attacking across z levels when wandering #3295)
fix: remove wield value frequency, fix cache invalidation (fix: remove wield value frequency, fix cache invalidation #3296)
Water purification tablets now work consistently (Water purification tablets now work consistently #3297)
Prying nails correctly deconstructs reinforced boarded window (Prying nails correctly deconstructs reinforced boarded window #3300)
Better shore line at 3 and 4 way junctions (Better shore line at 3 and 4 way junctions #3292)
perf: correctly cache and invalidate dead state (perf: correctly cache and invalidate dead state #3304)
Fix Repair Nanobots (Fix Repair Nanobots #3308)
Correct Typo in Faction Camp Workshops (Correct Typo in Faction Camp Workshops #3314)
Disallow dragging street lights, add to more locations (Disallow dragging street lights, add to more locations #3294)
Mark monster_speed_trig as mayfail (Mark monster_speed_trig as mayfail #3313)
Magiclysm additions: Goblins, Gear mods and Dragonbone! (Magiclysm additions: Goblins, Gear mods and Dragonbone! #3322)
Routine i18n updates on 2023-09-30 (Routine i18n updates on 2023-09-30 #3323)
Fix destroyed things being processed
Fix tidy warnings (Fix tidy warnings #3310)
Fix armor relayering
Check mx ids defined for region (Check mx ids defined for region #3303)
Voltmeter & pH meter rebalancing (Voltmeter & pH meter rebalancing #3336)
Some changes on certain comestible (Some changes on certain comestible #3332)
ci: always run matrix for merge queue (ci: always run build matrix test for merge queue #3327)
Cleanup and flesh out book morale interactions a bit (Cleanup and flesh out book morale interactions a bit #2910)
Further consistency updates for shotshells (Further consistency updates for shotshells #3335)
Allow resuming dark-craftable constructions in the dark (Allow resuming dark-craftable constructions in the dark #3333)
Port over two improvements to simple deconstruct (Port over two improvements to simple deconstruct #3334)
Update looks like for small battery furniture (Update looks like for small battery furniture #3337)
feat: alternative ear/tail mutation tiles (feat: prettier ear/tail mutation graphics #3340)
docs: alternative_mutation_tileset.png (docs: alternative_mutation_tileset.png #3342)
Fixed odd mapgen in house basement (Fixed odd mapgen in house basement #3344)
fix: tileset misplaced field name error (fix: misplaced field name error on mutation tileset #3345)
Fix bike shop drowning in street lights (Fix bike shop drowning in street lights #3348)
ci: trigger workflow on merge queue (ci: trigger workflow check on merge queue #3349)
Fixed some issues with displaying item's mods counter (Fixed some issues with displaying item's mods counter #3338)
Grey out invalid ammo in reload menu (Grey out incompatible ammo in reload menu #3341)
feat(balance): correct stats for fermenting pickles and eggs jar (feat(balance): correct stats for fermenting pickles and eggs jar #3343)
Update acid cannons (feat: acid trail for acid cannons #3339)
fix: make unused 22lr casing stackable (fix: make unused 22lr casing stackable #3356)
Lower Nomad Gear and Scavenger Gear Warmth (Lower Nomad Gear and Scavenger Gear Warmth #3361)
Updates for homemade explosive/flame ammo (Updates for homemade explosive/flame ammo #3360)
Fix unused reference to To Serve Man (Fix unused reference to To Serve Man #3362)
ci: validate that template extraction works (ci: validate that template extraction works #3353)
Rifled flintlock now actually spawns (Rifled flintlock now actually spawns #3357)
Implement "extend" for magazines (Implement "extend" for magazines #3261)
build(deps): bump postcss from 8.4.29 to 8.4.31 in /doc (build(deps): bump postcss from 8.4.29 to 8.4.31 in /doc #3363)
feat(port): jarless sourdoughs (feat(port): jarless sourdoughs #3352)
Revert "ci: trigger workflow on merge queue (ci: trigger workflow check on merge queue #3349)" (Revert "ci: trigger workflow check on merge queue" #3364)
ci: only deploy docs when needed (ci: only deploy docs when needed #3365)
Ported items flags optimization from DDA (Ported items flags optimization from DDA #3354)
fix: don't sink down a floor from stepladder (fix: don't sink down a floor from stepladder #3367)
Fix build fail due to REACH_ATTACK flag (Fix build fail due to REACH_ATTACK flag #3370)
Implement bastion star fort, flesh out layout (Implement bastion star fort, flesh out layout #3351)
Fix mission names misused as mission description (Fix mission names misused as mission description #3376)
Fix infinite loop in mine gen (Fix infinite loop in mine gen #3379)
Add flashlight to the Shock Tonfa (Add flashlight to the Shock Tonfa #3380)
Routine i18n updates on 2023-10-07 (Routine i18n updates on 2023-10-07 #3381)
Add recipes for smaller engines, engine block updates (Add recipes for smaller engines, engine block updates #3373)
Use std::optional for best_mode_for_range() (Use std::optional for best_mode_for_range() #3368)
perf: do not error on SDL sound failure (perf: do not error on SDL sound failure #3384)
perf: slightly speed up weight_carried_reduced_by and recalc_speed_bonus (perf: slightly speed up weight_carried_reduced_by and recalc_speed_bonus #3385)
(Port) Decouple encumbrance, max_encumbrance and coverage in armor on a per bodypart_id basis ((Port) Decouple encumbrance, max_encumbrance and coverage in armor on a per bodypart_id basis #2776)
fix: NPCs drop excess items if overburdened, merchants pick up and renew inventory if restocking (fix: NPCs drop excess items if overburdened, merchants pick up and renew inventory if restocking #3386)
fix: only NPCs drop items when overencumbered (fix: only NPCs drop items when overencumbered #3387)
Rebalance steam turbine relative to small gas turbine (Rebalance steam turbine relative to small gas turbine #3388)
Consistency updates for street light placement (Consistency updates for street light placement #3369)
Forgot the s (Forgot the s #3389)
fix gcc
style(autofix.ci): automated formatting
Fix filthy clothes
refactor: trailing return goes brrrrr
refactor: apply clang-tidy suggestions
perf: remove obsoleted colony tests
perf: remove flag usage for temperature display
perf: apply all clang-tidy performance fixes
perf: use emplace_back

applied clang-tidy to fix `-Wpessimizing-move`, and activiy being changed to pointer Co-authored-by: jove <[email protected]>

Co-authored-by: jove <[email protected]>

fix: various build blockers

build: 0.4 merge preparation

…actor

joveeater and others added 30 commits January 9, 2023 23:59

Temp commit, now with compiling

a12b47e

More refactoring

ad0ef91

vehicles fix

454ca13

More bugfixes and the start of the test suite

24b3ddd

Merge branch 'upload' into spring-refactor

16e53ef

Merge branch 'upload' into spring-refactor

2380410

More bugfixes

944cc0f

More bugfixes

a2b39d7

Beginning of better types

d60311c

More new stuff, no compiling

6b70aa5

More moving to smart pointers

7510577

Bit more

713af91

More more more

0da8198

MOAR

1110027

More

5d5897a

even more

6bcf8eb

style: typo item_spawn -> item::spawn

60c2393

style: remove unnecessary std::move, use -> for activity

50518b2

applied clang-tidy to fix `-Wpessimizing-move`, and activiy being changed to pointer Co-authored-by: jove <[email protected]>

fix: legacy null item reference

3553401

Co-authored-by: jove <[email protected]>

docs: return type of reduce_charges

0b12953

style: astyle

18112e1

Merge pull request #1 from scarf005/copy-elision

bcfe831

fix: various build blockers

Now with compiling

767c545

More fixes

189100b

More fixes

0209ed3

Pre-merge commit, fairly stable now

6d6a28f

Round out interfaces

4bd3a36

All merged up

c82307f

Better vehicles and cleanup

8c1c36a

Remove traces and better destruction

cd3aa3d

scarf005 and others added 27 commits September 24, 2023 02:46

fix: salvage test

0aee3c8

Merge remote-tracking branch 'upstream/upload' into spring-0.4

a3b3b47

Merge pull request #7 from scarf005/spring-0.4

d1d29c4

build: 0.4 merge preparation

style(autofix.ci): automated formatting

f87a168

submap rotate fixes

e6eb11a

Merge remote-tracking branch 'origin/spring-refactor' into spring-ref…

e5110a6

…actor

Shouldn't use uint

e9a4cc5

Merge branch 'upload' into spring-refactor

bee0ad4

And the rest

f6d0256

Merge branch 'upload' into spring-refactor

59afa89

Merge branch 'upload' into spring-refactor

c25aa04

Fix destroyed things being processed

30cd47a

Fix armor relayering

9dfd4c8

Merge branch 'upload' into spring-refactor

76b1b4f

Merge branch 'upload' into spring-refactor

e519498

Merge branch 'upload' into spring-refactor

e0dc0bb

Merge branch 'upload' into spring-refactor

0b4b6a5

fix gcc

b360544

style(autofix.ci): automated formatting

c3fc753

Fix filthy clothes

edbf095

Merge branch 'upload' into spring-refactor

283f7b4

refactor: trailing return goes brrrrr

9ef4863

refactor: apply clang-tidy suggestions

5a173ee

perf: remove obsoleted colony tests

afe72e5

perf: remove flag usage for temperature display

2401cf2

perf: apply all clang-tidy performance fixes

2586412

perf: use emplace_back

0d48dd8

github-actions bot added src changes related to source code. tests changes related to tests labels Oct 8, 2023

scarf005 closed this Oct 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perf: apply clang-tidy performance checks #3393

perf: apply clang-tidy performance checks #3393

scarf005 commented Oct 8, 2023

perf: apply clang-tidy performance checks #3393

perf: apply clang-tidy performance checks #3393

Conversation

scarf005 commented Oct 8, 2023